This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Don't use -mnew-mnemonics


On 9/14/2012 10:07 AM, Segher Boessenkool wrote:
> As reported in http://sourceware.org/ml/libc-alpha/2012-09/msg00353.html
> glibc still uses the old -mnew-mnemonics flag.  Here's a fix.
> 
> 2012-09-14  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> 	* sysdeps/powerpc/Makefile (cflags): Don't add -mnew-mnemonics.
> ---
>  sysdeps/powerpc/Makefile |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/sysdeps/powerpc/Makefile b/sysdeps/powerpc/Makefile
> index 79dd6fa..7442b67 100644
> --- a/sysdeps/powerpc/Makefile
> +++ b/sysdeps/powerpc/Makefile
> @@ -1,7 +1,3 @@
> -# We always want to use the new mnemonic syntax even if we are on a RS6000
> -# machine.
> -+cflags += -mnew-mnemonics
> -
>  ifeq ($(subdir),string)
>  CFLAGS-memcmp.c += -Wno-uninitialized
>  endif
> 

We support GCC 4.3 or newer.

Won't the older GCC's we support still need this flag?

Shouldn't this be conditional on the detected compiler version?

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]