This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Free errstring if _dl_addr returns 0
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 7 Sep 2012 13:24:24 -0700 (PDT)
- Subject: Re: [PATCH] Free errstring if _dl_addr returns 0
- References: <20120907184737.GA14053@intel.com>
It needs comments. You can just extend the comment at the top of that
block. While you're at it, fix the typo there ("namespave").
I don't see any way that _dl_addr return nonzero without setting MAP to
non-null, so that test can be removed.
Thanks,
Roland