This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Committed] S/390: Make IFUNC optimized mem* functions hidden
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Andreas Krebbel" <andreas at de dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 6 Sep 2012 12:45:24 -0700 (PDT)
- Subject: Re: [Committed] S/390: Make IFUNC optimized mem* functions hidden
- References: <20120903121454.GA11550@bart>
> + /* Make the declarations of the optimized functions hidden in order
> + to prevent GOT slots being generated for them. */ \
> + extern __attribute__((visibility("hidden"))) void *FUNC##_z196; \
> + extern __attribute__((visibility("hidden"))) void *FUNC##_z10; \
> + extern __attribute__((visibility("hidden"))) void *FUNC##_z900; \
This attribute syntax has wrong whitespace.
But you should just use the attribute_hidden macro anyway, it's shorter.
Also, it's our convention for declarations to put attributes at the end,
not before the type (before the type is the convention for definitions).
Thanks,
Roland