This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Use memcpy in memmove when possible
- From: Maxim Kuvyrkov <maxim at codesourcery dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, "Joseph S. Myers"<joseph at codesourcery dot com>
- Date: Sat, 1 Sep 2012 20:38:21 +1200
- Subject: Re: [PATCH] Use memcpy in memmove when possible
- References: <A9D6160A-41F1-48E7-851F-F2D4F7134EB3@codesourcery.com> <m28vcucfpi.fsf@igel.home>
On 1/09/2012, at 8:25 PM, Andreas Schwab wrote:
> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
>
>> @@ -79,10 +82,17 @@ MEMMOVE (a1, a2, len)
>>
>> /* There are just a few bytes to copy. Use byte memory operations. */
>> BYTE_COPY_FWD (dstp, srcp, len);
>> +#endif /* MEMCPY_OK_FOR_FWD_MEMMOVE */
>> +
>> + RETURN (dest);
>
> Why is it necessary to duplicate this?
You mean the RETURN? It's not necessary to duplicate it in both if- and then-branches, just a matter of personal coding taste.
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics