This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available
On 8/23/2012 3:02 PM, KOSAKI Motohiro wrote:
> On Wed, Aug 22, 2012 at 4:49 AM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> On Wed, 22 Aug 2012 00:06:10 +0530, Siddhesh wrote:
>>> ChangeLog:
>>>
>>> * malloc/arena.c: Include malloc-sysdep.h.
>>> (shrink_heap): New static variable may_shrink_heap to decide
>>> if madvise is sufficient to shrink the heap or an unmap is needed.
>>> * sysdeps/generic/Makefile (sysdep_headers): Add
>>> malloc-sysdep.h as a dependency when building malloc.
>>> * sysdeps/generic/malloc-sysdep.h: New file. Define
>>> new function check_may_shrink_heap.
>>> * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Add
>>> malloc-sysdep.h as dependency when building malloc.
>>> * sysdeps/unix/sysv/linux/malloc-sysdep.h: New file. Define
>>> new function check_may_shrink_heap.
>>>
>>
>> I have attached an updated patch after Florian pointed out that I had
>> leaked a file descriptor. The ChangeLog remains the same.
>
> I have no seen any issue in this patch. but, as you know, i'm not a maintainer.
> please get a formal review from proper reviewers.
Doing the work of a reviewer makes you a maintainer in a consensus based project.
Sorry for hijaking the thread, but I felt I had to thank Motohiro-san for his good work :-)
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026