This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available

From: KOSAKI Motohiro <kosaki dot motohiro at gmail dot com>
To: Siddhesh Poyarekar <siddhesh at redhat dot com>
Cc: "Carlos O'Donell" <carlos at systemhalted dot org>, Rich Felker <dalias at aerifal dot cx>, libc-alpha at sourceware dot org
Date: Thu, 23 Aug 2012 15:02:00 -0400
Subject: Re: [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available
References: <20120720223800.GB26330@sunsite.ms.mff.cuni.cz><20120720224417.E8BEF2C0CA@topped-with-meat.com> <20120721061814.GC26330@sunsite.ms.mff.cuni.cz><20120721133217.GY544@brightrain.aerifal.cx> <20120725183634.E0C5F2C0B1@topped-with-meat.com><CAHGf_=qCMy6K1MD4miN65GkMSumYTtH23xoFrfmCuh=WjybAVA@mail.gmail.com><20120730230006.355f9b67@spoyarek> <5016D012.5000101@gmail.com><20120730191758.GX544@brightrain.aerifal.cx> <CAHGf_=rRm4B4YCZKgos5hWN_QTYV76fAxcegO7D3x=4_A88Rvw@mail.gmail.com><20120731132705.GZ544@brightrain.aerifal.cx> <CAHGf_=pN3KJGL_V1tQ2+o0=-RY4q2du7PJDnak9y7xyzYiH1tQ@mail.gmail.com><20120810235226.408e3cec@spoyarek> <CADZpyiz05WnMqrREEtSs+oW_0Ld6hnfxbmFMk_hKYL-P_gFTag@mail.gmail.com><20120811205228.42ab905f@spoyarek> <CADZpyizkMLBGK13-h-YH_CpVgbcx3n7gbxYAwxzsdbiEJOMNjg@mail.gmail.com><50289F84.9060205@gmail.com> <20120822000610.6110da3f@spoyarek> <20120822141946.7702d182@spoyarek>

On Wed, Aug 22, 2012 at 4:49 AM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Wed, 22 Aug 2012 00:06:10 +0530, Siddhesh wrote:
>> ChangeLog:
>>
>>       * malloc/arena.c: Include malloc-sysdep.h.
>>       (shrink_heap): New static variable may_shrink_heap to decide
>> if madvise is sufficient to shrink the heap or an unmap is needed.
>>       * sysdeps/generic/Makefile (sysdep_headers): Add
>>       malloc-sysdep.h as a dependency when building malloc.
>>       * sysdeps/generic/malloc-sysdep.h: New file.  Define
>>       new function check_may_shrink_heap.
>>       * sysdeps/unix/sysv/linux/Makefile (sysdep_headers): Add
>>       malloc-sysdep.h as dependency when building malloc.
>>       * sysdeps/unix/sysv/linux/malloc-sysdep.h: New file.  Define
>>       new function check_may_shrink_heap.
>>
>
> I have attached an updated patch after Florian pointed out that I had
> leaked a file descriptor. The ChangeLog remains the same.

I have no seen any issue in this patch. but, as you know,  i'm not a maintainer.
please get a formal review from proper reviewers.

thx.

Follow-Ups:
- Re: [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available
  - From: Carlos O'Donell

References:
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: KOSAKI Motohiro
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: Siddhesh Poyarekar
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: Carlos O'Donell
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: Siddhesh Poyarekar
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: Carlos O'Donell
- Re: [PATCH][RFC] Allow explicit shrinking of arena heaps using anenvironment variable
  - From: KOSAKI Motohiro
- [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available
  - From: Siddhesh Poyarekar
- Re: [PATCH v2] Allow shrinking of arena heaps using mmap based onovercommit settings when available
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]