This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Make dl-fxstatat64.c include of fxstatat64.c use <> not ""


sysdeps/unix/sysv/linux/dl-fxstatat64.c does #include "fxstatat64.c", 
meaning it includes the fxstatat64.c in the same directory and so if an 
architecture overrides fxstatat64.c it should also override 
dl-fxstatat64.c.  In particular, MIPS64 wrongly gets 
sysdeps/unix/sysv/linux/fxstatat64.c included from dl-fxstatat64.c instead 
of the MIPS64-specific fxstatat64.c.  Is there a reason for the present 
arrangement, or should it use <> as in the patch below, which gets the 
right file included for MIPS64?  (The alternative fix for MIPS64 is 
copying dl-fxstatat64.c to ports/sysdeps/unix/sysv/linux/mips/mips64/, but 
it seems better to avoid the copying if there isn't a reason for use of "" 
in #include here.)

(This is the second bit of preparation for removing 
__ASSUME_STAT64_SYSCALL.)

2012-08-22  Joseph Myers  <joseph@codesourcery.com>

	* sysdeps/unix/sysv/linux/dl-fxstatat64.c: Use <> instead of "" in
	#include of fxstatat64.c.

diff --git a/sysdeps/unix/sysv/linux/dl-fxstatat64.c b/sysdeps/unix/sysv/linux/dl-fxstatat64.c
index 9a17a9b..1f8c2e6 100644
--- a/sysdeps/unix/sysv/linux/dl-fxstatat64.c
+++ b/sysdeps/unix/sysv/linux/dl-fxstatat64.c
@@ -3,4 +3,4 @@
    function in this case.  */
 #undef __ASSUME_ATFCTS
 #define __ASSUME_ATFCTS 1
-#include "fxstatat64.c"
+#include <fxstatat64.c>

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]