This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] alpha, ia64, m68k, mips, sh, sparc: *_gnu_pltenter should allow modification of struct La_*_regs.


On Wednesday 15 August 2012 20:34:01 Carlos O'Donell wrote:
> The *_gnu_pltenter interface allows the modification of the incoming
> set of registers in struct La_*_regs, that is to say that the 5th
> argument of la_*_pltenter() is non-constant.
> 
> This was not always the case, but it is the case now and has been
> since it was silently changed in commit
> 2413fdba7a02ba8916f75d17199a6e9133a8f7b0.
> 
> Removing const from the 5th argument conforms with the Solaris interface:
> http://docs.oracle.com/cd/E19082-01/819-0690/chapter6-1242/index.html
> 
> Removing const for alpha, ia64, m68k, mips, sh, and sparc conforms
> with what the other machines in glibc are already doing.
> 
> I haven't tested this, but I don't think anything should go wrong
> given the wide usage of the non-const version right now. We could also
> do with a better test case that does something with the registers.
> For now I'm content to cleanup the definition in ldsodefs.h.
> 
> OK to commit?

ia64 looks fine
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]