This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [BZ #14090] Fix md5/sha512 with large block sizes
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 15 Aug 2012 11:34:12 -0700 (PDT)
- Subject: Re: [BZ #14090] Fix md5/sha512 with large block sizes
- References: <hor4ryd5lc.fsf@byrd.suse.de><20120726205214.777E22C107@topped-with-meat.com><50125297.80904@suse.com><20120727164210.4DE912C105@topped-with-meat.com><5012EAF3.1040108@suse.com><502BDFCE.5020406@suse.com><20120815180020.B7F1F2C0F2@topped-with-meat.com><502BE67B.4050204@suse.com>
> + /* This test will not work with 32-bit size_t, so let it succeed
> there. */
This comment looks indented and wrapped wrong.
> +#if __WORDSIZE == 32
The meaning of __WORDSIZE is fuzzy and we keep talking about changing it.
Instead let's include <limits.h> and use:
#if SIZE_MAX <= UINT32_MAX
Otherwise fine.
Thanks,
Roland