This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH x86_64 only: optimize sinf and cosf with SSE2
- From: Markus Trippelsdorf <markus at trippelsdorf dot de>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org,Dmitrieva Liubov <liubov dot dmitrieva at gmail dot com>
- Date: Thu, 9 Aug 2012 11:20:38 +0200
- Subject: Re: PATCH x86_64 only: optimize sinf and cosf with SSE2
- References: <CAHjhQ93BHjbVMTeqLtKFf4YSEyEhA0B4EwPQghwQs_aU+n_eCw@mail.gmail.com><CAHjhQ91F0PyTuLfQV1mC37PWeP0sysS8A=HwnzqLqpAudRdu4A@mail.gmail.com><2776177.BxWO0Hf2V5@byrd>
On 2012.08.09 at 10:39 +0200, Andreas Jaeger wrote:
> On Thursday, August 09, 2012 12:16:06 Dmitrieva Liubov wrote:
> > Repost of the patch with opimized SINF and COSF for x86_64.
> >
> > http://sourceware.org/ml/libc-alpha/2012-06/msg00692.html
> >
> > We are looking forward to accepting and releasing this.
>
> Btw. if you could look at this bugreport as well and provide an
> optimized sincos implementation, it would be appreciated:
> http://sourceware.org/bugzilla/show_bug.cgi?id=14412
>
> Just a few comments on your submission:
>
> * Please add a copyright header.
> * Instead of defining EDOM, I suggest to:
> #include <bits/errno.h>
>
> * For your comments, follow the usual style - with two spaces after "."
> or "?" - and no space before
Also ASM_TYPE_DIRECTIVE{,_PREFIX} was removed a few days ago (commit
b67e9372b28ef33). Please use ".type L(FOO),@object" instead.
--
Markus