This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Define secure_getenv (v2)


On 7/30/2012 9:07 AM, Florian Weimer wrote:
> On 07/27/2012 02:58 PM, Carlos O'Donell wrote:
>> On 7/27/2012 8:53 AM, Florian Weimer wrote:
>>> On 07/27/2012 02:52 PM, Carlos O'Donell wrote:
>>>
>>>> Please tweak the test not to fail and issue a warning when the supplementary
>>>> group is missing.
>>>
>>> Should I print the warning to stderr or stdout?
>>
>> Good question. Given that this is a warning about the test itself,
>> not the thing that the test is testing, I would output this to
>> stderr. That way a view of stderr would show the warning along with
>> other warnings about the build.
> 
> What about this?  Tested on x86_64-redhat-linux-gnu, also with a user without supplementary GIDs.
> 

This looks good to me.

You've converted everything to use stdout, with the exception
of the detection for a suitable GID, which still prints to
stderr but because we don't consider it a failure you exit
with exit(0).

This matches what Siddhesh has summarizing here:
http://sourceware.org/glibc/wiki/Testing/Testsuite

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]