This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Suppress sign-conversion warning from FD_SET
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: Mike Frysinger <vapier at gentoo dot org>, <libc-alpha at sourceware dot org>, PaulPluzhnikov <ppluzhnikov at google dot com>, Pedro Alves <palves at redhat dot com>,<yunlian at google dot com>
- Date: Wed, 13 Jun 2012 11:29:33 -0400
- Subject: Re: [PATCH] Suppress sign-conversion warning from FD_SET
- References: <20120525162702.053F819076C@elbrus2.mtv.corp.google.com> <4FC49810.5090203@redhat.com> <CALoOobOMaSQNOHudNhMQxOu+6Wd3Tsw3Ye=Hs_R_-5Rx19tv_Q@mail.gmail.com> <201206130036.47712.vapier@gentoo.org> <4FD8A718.5070309@mentor.com> <4FD8A969.60500@cs.ucla.edu>
On 6/13/2012 10:53 AM, Paul Eggert wrote:
> On 06/13/2012 07:43 AM, Carlos O'Donell wrote:
>> Could you please repost the final patch and I'll ACK that?
>
> Here it is, taken from the attachment to Paul Pluzhnikov's email
> <http://sourceware.org/ml/libc-alpha/2012-05/msg01879.html>.
> I just now wrote the ChangeLog entry.
>
> 2012-06-13 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> Suppress sign-conversion warning from FD_SET.
> See <http://sourceware.org/ml/libc-alpha/2012-05/msg01794.html>.
> * debug/fdelt_chk.c (__fdelt_chk): Accept and return long int,
> not unsigned long int.
> * misc/bits/select2.h (__fdelt_chk, __fdelt_warn, __FD_ELT): Likewise.
This looks good to me. Please check this in.
Thanks to everyone who worked out the details for this :-)
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026