This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] fix warnings in sys/select.h fortification with -Wsign-conversion
> 2012-06-08 Mike Frysinger <vapier@gentoo.org>
>
> * misc/bits/select2.h (__FD_ELT): Cast d to unsigned long int.
Put D in caps here.
> --- a/misc/bits/select2.h
> +++ b/misc/bits/select2.h
> @@ -27,7 +27,7 @@ extern unsigned long int __fdelt_warn (unsigned long int __d)
> #undef __FD_ELT
> #define __FD_ELT(d) \
> __extension__ \
> - ({ unsigned long int __d = (d); \
> + ({ unsigned long int __d = (unsigned long int) (d); \
I think this merits a comment about why the cast is required.
This seems to me like a reasonable candidate to come in despite the
freeze. But then it certainly needs to start with a bugzilla report
and have that number in the log entry, and then you get to convince
Carlos that it's an appropriate bug fix.
Thanks,
Roland