This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Use i386 sys/elf.h and sys/vm86.h for i386 and x86-64


On Fri, Jun 1, 2012 at 1:07 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> ? ? ? * sysdeps/unix/sysv/linux/i386/Makefile (sysdep_headers):
>> ? ? ? Don't add sys/elf.h sys/perm.h sys/reg.h sys/vm86.h
>> ? ? ? sys/debugreg.h sys/io.h here.
>> ? ? ? * sysdeps/unix/sysv/linux/x86/Makefile (sysdep_headers): Add
>> ? ? ? sys/elf.h sys/perm.h sys/reg.h sys/vm86.h sys/debugreg.h
>> ? ? ? sys/io.h.
>> ? ? ? * sysdeps/unix/sysv/linux/x86_64/Makefile (sysdep_headers):
>> ? ? ? Don't add sys/perm.h sys/reg.h sys/debugreg.h sys/io.h here.
>>
>> ? ? ? * sysdeps/unix/sysv/linux/i386/sys/elf.h: Renamed to ...
>> ? ? ? * sysdeps/unix/sysv/linux/x86/sys/elf.h: This.
>> ? ? ? * sysdeps/unix/sysv/linux/i386/sys/vm86.h: Renamed to ...
>> ? ? ? * sysdeps/unix/sysv/linux/x86/sys/vm86.h: This.
>
> Drop the blank line. ?You also should be moving x86_64/sys/io.h to x86/
> and removing i386/sys/io.h.

Please review:

http://sourceware.org/ml/libc-alpha/2012-05/msg02019.html

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]