This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Fix for POWER7 sinf/cosf
- From: Adhemerval Zanella <azanella at linux dot vnet dot ibm dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, "Ryan S. Arnold" <ryan dot arnold at gmail dot com>, "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Fri, 01 Jun 2012 10:14:47 -0300
- Subject: Re: [PATCH] PowerPC: Fix for POWER7 sinf/cosf
- References: <4FC558B1.2090309@linux.vnet.ibm.com> <CAAKybw-r57hOcOuOHbQeW-A-BPoFjQzuQKdkSrxYwjRJ1065Yg@mail.gmail.com> <m2aa0qb1n9.fsf@igel.home> <CAAKybw9C_PSdRKcxGs-V1mVHoC8F8cd3j56JNkOn7Sg6peKwew@mail.gmail.com> <m2txyw6wj6.fsf@igel.home> <20120531224426.917A32C097@topped-with-meat.com> <4FC8074E.40406@linux.vnet.ibm.com>
On 05/31/2012 09:05 PM, Adhemerval Zanella wrote:
> On 05/31/2012 07:44 PM, Roland McGrath wrote:
>>> The point of hidden_proto is that you don't need to distinguish between
>>> the internal and external name.
>> That's not true. The point of hidden_proto is to avoid a PLT. That
>> incidentally means that which name you use doesn't really matter for the
>> shared libraries. In the static libraries, there is still the name space
>> concern to worry about. So, if this is a C89 function calling a function
>> that is not in C89, then you need to use the __ name.
>>
>>
>> Thanks,
>> Roland
>>
> Ok, I'll add <fenv.h> and replace feraiseexcept by __feraiseexcept to commit.
> Thanks for the feedback.
>
>
Pushed upstream as git commit 73a68f94d650ac485db6b95242e1cb6591b193d3
--
Adhemerval Zanella Netto
Software Engineer
Linux Technology Center Brazil
Toolchain / GLIBC on Power Architecture
azanella@linux.vnet.ibm.com / azanella@br.ibm.com
+55 61 8642-9890