This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use the same set of header files for x86-64 and i386


On Wed, May 30, 2012 at 12:03 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Wed, 30 May 2012, H.J. Lu wrote:
>
>> Here is a patch to use the same set of header files for x86-64 and i386.
>> It is on hjl/pr14117 branch. ?This change is pretty much straight
>> forward by using x86-64 headers for both x86-64 and i386. ?There are
>> 3 exceptions:
>
> This doesn't deal with sysdeps/i386/fpu / sysdeps/x86_64/fpu headers - I
> suppose you'll deal with those separately.

I will add them.

> What I want to see for such a patch is not so much the source code diff as
> a before-and-after diff of the installed headers for i386. ?That's what
> needs reviewing - whether there are any semantic changes to the headers
> installed for 32-bit glibc. ?And I think this will need splitting up into
> smaller pieces that are easier to review (each one with its own
> before-and-after diff of installed headers).
>

I can do that if it will be reviewed quickly.

Thanks.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]