This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x86-64 bits/utmp.h and bits/utmpx.h


> 	* sysdeps/gnu/bits/utmp.h (lastlog): Check __WORDSIZE_TIME64_COMPAT32
> 	instead of __WORDSIZE and __WORDSIZE_COMPAT32.
> 	(utmp): Likewise.
> 	* sysdeps/gnu/bits/utmpx.h (utmpx): Likewise.

(struct lastlog)
(struct utmp)
(struct utmpx)

When mentioning #if stuff, write it like this:

Check [__WORDSIZE_TIME64_COMPAT32] instead of 
[__WORDSIZE == 64 && __WORDSIZE_COMPAT32].

> 	* sysdeps/powerpc/powerpc32/bits/wordsize.h (__WORDSIZE_COMPAT32):
> 	Renamed to ...
> 	(__WORDSIZE_TIME64_COMPAT32): This.

I didn't realize this was the only use of __WORDSIZE_COMPAT32.
Since it is, I think this is fine.  But the maintainers for all
the affected machines should have an opportunity to object.

> +#ifdef __x86_64__
> +# define __WORDSIZE_TIME64_COMPAT32		1
> +# define __WORDSIZE_NO_STATVFSBUF_F_UNUSED	1
> +#endif

__WORDSIZE_NO_STATVFSBUF_F_UNUSED is unrelated to this change and does not
belong in the same commit.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]