This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [PowerPC] Remove -ftree-loop-linear from Makefiles
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 18 May 2012 07:55:21 -0500
- Subject: Re: [PATCH] [PowerPC] Remove -ftree-loop-linear from Makefiles
- References: <1337174367-5519-1-git-send-email-tuliom@linux.vnet.ibm.com>
On Wed, May 16, 2012 at 8:19 AM, Tulio Magno Quites Machado Filho
<tuliom@linux.vnet.ibm.com> wrote:
> In the past the "-ftree-loop-linear" switch provided a
> measurable improvement in performance for certain functions. ÂAt
> some point it was assigned as the responsibility of Graphite in
> GCC. ÂIt has been found that even with Graphite enabled these
> flags no longer perform any appreciable improvement over the
> baseline.
>
> Graphite now has some open bugs which need to be fixed in order
> for it to provide measurable performance improvements but it
> lacks active development. ÂAs a result some compiler
> distributors may disable Graphite. ÂIf Graphite is disabled then
> building GLIBC will fail if the "-ftree-loop-linear" switch is used.
>
> This patch removes the use of "-ftree-loop-linear" as unnecessary.
>
> 2012-05-14 Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com>
>
> Â Â Â Â* sysdeps/powerpc/powerpc32/power4/Makefile (CFLAGS-wordcopy.c,
> Â Â Â ÂCFLAGS-memmove.c): remove -ftree-loop-linear.
> Â Â Â Â* sysdeps/powerpc/powerpc32/power4/fpu/Makefile (CFLAGS-mpa.c):
> Â Â Â ÂLikewise.
> Â Â Â Â* sysdeps/powerpc/powerpc64/power4/Makefile (CFLAGS-wordcopy.c,
> Â Â Â ÂCFLAGS-memmove.c): Likewise.
> Â Â Â Â* sysdeps/powerpc/powerpc64/power4/fpu/Makefile (CFLAGS-mpa.c):
> Â Â Â ÂLikewise.
> ---
> Âsysdeps/powerpc/powerpc32/power4/Makefile   |  Â4 ++--
> Âsysdeps/powerpc/powerpc32/power4/fpu/Makefile | Â Â2 +-
> Âsysdeps/powerpc/powerpc64/power4/Makefile   |  Â4 ++--
> Âsysdeps/powerpc/powerpc64/power4/fpu/Makefile | Â Â2 +-
> Â4 files changed, 6 insertions(+), 6 deletions(-)
This patch looks good to me. I'm going to commit later today. Thanks Tulio.
Ryan S. Arnold