This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add dummy files for x32
> On Wed, May 16, 2012 at 9:57 AM, Roland McGrath <roland@hack.frob.com> wrote:
> > symbol-hacks.h will have no effect if the compiler doesn't actually emit
> > those calls. ?So don't bother to add it. ?The empty divdi3.c is fine.
> >
> > Thanks,
> > Roland
>
> ./sysdeps/wordsize-32/symbol-hacks.h has
>
>
> #if !defined __ASSEMBLER__ && !defined in_divdi3_c && !defined NOT_IN_libc && de
> fined SHARED
> asm ("__divdi3 = __divdi3_internal");
> asm ("__udivdi3 = __udivdi3_internal");
> asm ("__moddi3 = __moddi3_internal");
> asm ("__umoddi3 = __umoddi3_internal");
> #endif
>
> and
>
> sysdeps/wordsize-32/Makefile has
>
> CPPFLAGS-divdi3.c = -Din_divdi3_c
>
> Does it lead to undefined symbols?
Oh, apparently it does. OK, then your original change is fine.
Thanks,
Roland