This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/7] Export AT_HWCAP from libc, v3
On 05/14/2012 06:40 PM, Richard Henderson wrote:
Version 2 didn't receive much in the way of comment...
Changes v2->v3:
Update libc.abilist.
Changes v1->v2:
Renamed<sys/hwcap.h> to<sys/auxv.h>
Renamed __libc_hwcap to gethwcap.
Added getauxval.
The type we save for gethwcap is larger than the type we
received in ElfW(auxv_t); I'd like to return all of it to
allow libc to massage the value if desired, so I've kept
the separate accessor function.
The code change looks fine to me. I miss a couple of comments and
mentioned those. If those are added, the patch is IMO good for adding to
glibc.
Since this is a new glibc interface, I'd like another reviewer that
looks at the design - checking the interface itself is well defined and
usable,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126