This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add sysdeps/x86_64/x32/tls.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 May 2012 13:55:52 -0700 (PDT)
- Subject: Re: PATCH: Add sysdeps/x86_64/x32/tls.h
- References: <20120511153058.GA12184@intel.com>
That is OK but it would be better with a comment explaining why it's
necessary. You only mentioned the need to use a register temporary
because an indirect call would load too much from the pointer, but
it also matters that the load of the argument register would load
too much and have other stuff in the high bits rather than the
zero-extension that you do here. The comment should mention that
both issues matter.
Thanks,
Roland