This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS

On Mon, May 7, 2012 at 8:05 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Monday 07 May 2012 10:00:30 Carlos O'Donell wrote:
>> I'm OK with this patch provided you include a comment in
>> debug/Makefile stating why you can't just use CFLAGS.
>
> ok
>
>> Doesn't this effect *every* test that adds their own test-specific flags?
>
> yes, but i just picked the places where this matters in practice (at least, to
> me). ?the other -D flags are much more unlikely to get trumped by the user's
> settings.

Thanks, that makes sense. I think it's good to be pragmatic here.

Cheers,
Carlos.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]