This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] BZ #13979- A warning should be issued if FORTIFY_SOURCEis requested but not enabled

From: Jeff Law <law at redhat dot com>
To: Andreas Jaeger <aj at suse dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Mon, 07 May 2012 15:10:38 -0600
Subject: Re: [PATCH] BZ #13979- A warning should be issued if FORTIFY_SOURCEis requested but not enabled
References: <4FA83974.3010005@suse.com>

On 05/07/2012 03:07 PM, Andreas Jaeger wrote:

From bugzilla:
"If a user requests FORTIFY_SOURCE checking, but for whatever reason the
checks
are not enabled (for example optimizer not enabled), we should issue a
warning."
Tested on x86-64.

Ok to commit?

Andreas

2012-03-30 Jeff Law <law@redhat.com>_FORTIFY_SOURCE requested but disabled, please enable optimizer to restore fortification
* include/features.h: Warn if user requests FORTIFY_SOURCE checking
but the checks are disabled for any reason.

Just a note, Fedora just twiddled the message today to read:

_FORTIFY_SOURCE requested but disabled, please enable optimizer to restore fortification

Basically the idea being to tell the user the most likely way to restore the behaviour they asked for.

jeff

References:
- [PATCH] BZ #13979- A warning should be issued if FORTIFY_SOURCE isrequested but not enabled
  - From: Andreas Jaeger

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]