This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Move x86-64 abilist files to 64/nptl
On Wed, May 2, 2012 at 12:41 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, May 2, 2012 at 9:39 AM, Carlos O'Donell <carlos@systemhalted.org> wrote:
>> 2012/4/30 H.J. Lu <hongjiu.lu@intel.com>:
>>> Hi,
>>>
>>> X32 abilist files are different from x86-64 ones. ?This patch moves
>>> x86-64 abilist files to 64/nptl. ?Tested on Linux/x86-64. ?OK to install?
>>
>> How does the 64/ directory get used to find the abilist files for x86-64?
>>
>> I think the idea you have here is correct, namely that we need to
>> store two sets of abilist files for x86-64 and x32 in one machine
>> directory.
>>
>
> sysdeps/x86_64/preconfigure.in has
>
> test -n "$base_machine" || case "$machine" in
> x86_64)
> ?base_machine=x86_64
> ?# Check if we are building for x32.
> ?AC_CACHE_CHECK(whether $CC compiles in -mx32 mode by default,
> ? ? ? ? ? ? ? ? libc_cv_x32, [dnl
> ?AC_TRY_COMPILE(dnl
> [#ifndef __ILP32__
> # error not x32
> #endif], [], libc_cv_x32=yes, libc_cv_x32=no)])
> ?if test $libc_cv_x32 = yes; then
> ? ?machine=x86_64/x32
> ?else
> ? ?machine=x86_64/64
> ?fi
> ?;;
> esac
>
> x86_64/64 is searched when __ILP32__ isn't defined.
Excellent, that makes sense.
In that case I'm happy with your patch.
Please check this in on Friday if nobody else has any objections.
Cheers,
Carlos.