This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove all traces of reg_char.
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: David Miller <davem at davemloft dot net>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 18 Apr 2012 17:46:21 -0400
- Subject: Re: [PATCH] Remove all traces of reg_char.
- References: <20120418.170915.1069462961405738395.davem@davemloft.net>
On Wed, Apr 18, 2012 at 5:09 PM, David Miller <davem@davemloft.net> wrote:
>
> As mentioned, sparc was the only overrider of reg_char's
> definition and now it no longer does so.
>
> So we can remove this and simply use plain 'char' everywhere.
>
> Ok to commit?
>
> ? ? ? ?* sysdeps/generic/memcopy.h (reg_char): Delete.
> ? ? ? ?* debug/strcat_chk.c: Use char, not reg_char.
> ? ? ? ?* debug/strcpy_chk.c: Likewise.
> ? ? ? ?* debug/strncat_chk.c: Likewise.
> ? ? ? ?* debug/strncpy_chk.c: Likewise.
> ? ? ? ?* string/memchr.c: Likewise.
> ? ? ? ?* string/memrchr.c: Likewise.
> ? ? ? ?* string/rawmemchr.c: Likewise.
> ? ? ? ?* string/strcat.c: Likewise.
> ? ? ? ?* string/strchr.c: Likewise.
> ? ? ? ?* string/strchrnul.c: Likewise.
> ? ? ? ?* string/strcmp.c: Likewise.
> ? ? ? ?* string/strcpy.c: Likewise.
> ? ? ? ?* string/strncat.c: Likewise.
> ? ? ? ?* string/strncmp.c: Likewise.
> ? ? ? ?* string/strncpy.c: Likewise.
This looks good to me.
I double checked your files and they match what I expect.
Please check this in.
Cheers,
Carlos.