This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch][trivial] Cleanup: delete unused TLS_{GET,SET}_FS
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: libc-alpha at sourceware dot org
- Cc: ppluzhnikov at google dot com
- Date: Wed, 18 Apr 2012 13:28:00 -0700
- Subject: Re: [patch][trivial] Cleanup: delete unused TLS_{GET,SET}_FS
- References: <20120412172023.99B0219096D@elbrus2.mtv.corp.google.com>
Ping?
On Thu, Apr 12, 2012 at 10:20 AM, Paul Pluzhnikov
<ppluzhnikov@google.com> wrote:
> Greetings,
>
> I can't find any current or past use of TLS_GET_FS and TLS_SET_FS, and
> the patch below deletes them.
>
> Tested by building on Linux/x86_64.
> Ok for trunk?
>
> Thanks,
> --
> Paul Pluzhnikov
>
> 2012-04-12 ?Paul Pluzhnikov ?<ppluzhnikov@google.com>
>
> ? ? ? ?* nptl/sysdeps/x86_64/tls.h (TLS_GET_FS): Delete.
> ? ? ? ?(TLS_SET_FS): Likewise.
>
>
>
> diff --git a/nptl/sysdeps/x86_64/tls.h b/nptl/sysdeps/x86_64/tls.h
> index f644f0d..17c2286 100644
> --- a/nptl/sysdeps/x86_64/tls.h
> +++ b/nptl/sysdeps/x86_64/tls.h
> @@ -133,13 +133,6 @@ typedef struct
> ? (((tcbhead_t *) (descr))->dtv)
>
>
> -/* Macros to load from and store into segment registers. ?*/
> -# define TLS_GET_FS() \
> - ?({ int __seg; __asm ("movl %%fs, %0" : "=q" (__seg)); __seg; })
> -# define TLS_SET_FS(val) \
> - ?__asm ("movl %0, %%fs" :: "q" (val))
> -
> -
> ?/* Code to initially initialize the thread pointer. ?This might need
> ? ?special attention since 'errno' is not yet available and if the
> ? ?operation can cause a failure 'errno' must not be touched.
--
Paul Pluzhnikov