This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix test suite failures with --as-needed
On 16/04/12 19:50, Andreas Jaeger wrote:
> On Monday, April 16, 2012 11:39:39 Allan McRae wrote:
>> Running the testsuite with -Wl,--as-needed in LDFLAGS introduces the
>> following test failures:
>
> Does building glibc itself with --as-needed in LDFLAGS work now? I remember
> it does not, so I wonder.
>
I have been building glibc (and the rest of the toolchain) for Arch
Linux with --as-needed for a couple of years now and testsuite failures
like these are the only issues I have noticed.
>> make[2]: *** [/build/src/glibc-build/stdlib/tst-putenv.out] Error 1
>> make[2]: *** [/build/src/glibc-build/nptl/tst-cancel24] Error 1
>> make[2]: *** [/build/src/glibc-build/nptl/tst-tls6.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/nodelete2.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/next.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/reldep5.out] Error 127
>> make[2]: *** [/build/src/glibc-build/elf/reldep8.out] Error 134
>> make[2]: *** [/build/src/glibc-build/elf/noload.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/unload4.out] Error 127
>> make[2]: *** [/build/src/glibc-build/elf/order2.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/reldep6.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/tst-initorder2.out] Error 1
>> make[2]: *** [/build/src/glibc-build/elf/tst-initorder.out] Error 1
>>
>> Add $(no-as-needed) to LDFLAGS where required to fix this.
>>
>> Tested i686 and x86_64 linux.
>>
>>
>> 2012-04-16 Allan McRae <allan@archlinux.org>
>>
>> * elf/Makefile: Fix linking tests with --as-needed
>> * nptl/Makefile: Likewise
>> * stdlib/Makefile: Likewise
>
> This needs a separate ChangeLog entry for nptl/ChangeLog for nptl/Makefile.
>
> We also add "." at the end of entries.
>
> The changes itself look fine to me but I'd like to have somebody else
> review this as well and look at whether we should support this at all
Fair enough. I can send a fixed ChangeLog entry if the changes is
acceptable.
> Allan, thanks for the patch!
>
> Andreas