This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 10/13] Move sysdeps/sparc/{,sparc32,sparc64}/elf files


From: Andreas Jaeger <aj@suse.de>
Date: Fri, 23 Mar 2012 20:50:30 +0100

> On 03/23/2012 08:40 PM, David Miller wrote:
>> From: Andreas Jaeger<aj@suse.de>
>> Date: Fri, 23 Mar 2012 17:37:30 +0100
>>
>>> diff --git a/sysdeps/sparc/sparc64/Makefile
>>> b/sysdeps/sparc/sparc64/Makefile
>>> index 2b7b830..8f8a36d 100644
>>> --- a/sysdeps/sparc/sparc64/Makefile
>>> +++ b/sysdeps/sparc/sparc64/Makefile
>>> @@ -15,3 +15,6 @@ ASFLAGS-.og += -Wa,-Av9d
>>>   ASFLAGS-.ob += -Wa,-Av9d
>>>   ASFLAGS-.oS += -Wa,-Av9d
>>>   endif
>>> +
>>> +# The assembler on SPARC needs the -fPIC flag even when it's
>>> assembler code.
>>> +ASFLAGS-.os = -fPIC
>>
>> This new assignment clobbers the carefully set values made
>> above.
> 
> It's not entirely new

It's new to this file and I certainly know where it comes from.

> So, would this be correct?
> ASFLAGS-start.os = -fPIC

See the fix I posted, you simply have to set this before
the -Wa,-Av9{a,d} part gets added so that part doesn't get
lost.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]