Re: PATCH: Add x32 support to dynamic linker audit

["Carlos O'Donell" <carlos at systemhalted dot org>]

On Thu, Mar 22, 2012 at 12:43 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, Mar 22, 2012 at 9:40 AM, Carlos O'Donell
> <carlos@systemhalted.org> wrote:
>> On Thu, Mar 22, 2012 at 12:37 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>>>>>> --- a/sysdeps/generic/ldsodefs.h
>>>>>>> +++ b/sysdeps/generic/ldsodefs.h
>>>>>>> @@ -187,6 +187,8 @@ struct La_i86_regs;
>>>>>>> ?struct La_i86_retval;
>>>>>>> ?struct La_x86_64_regs;
>>>>>>> ?struct La_x86_64_retval;
>>>>>>> +struct La_x32_regs;
>>>>>>> +struct La_x32_retval;
>>>>>>
>>>>>> That's wrong. ?These structs don't exist.
>>>>>>
>>>>>
>>>>> You can use them, which are just mapped to x86_64 ones.
>>>>
>>>> What's the problem with them not existing? Debug information?
>>>>
>>>> You could typedef the x32 ones instead of macro-izing it.
>>>>
>>>
>>> Does typedef work with "struct xxx"?
>>
>> I'd like to know what the problem is with these structures not existing?
>>
>
> I don't believe there is a real problem.

Thanks.

Until Andreas comes back with a technical reason I don't think there
is anything else to do.

Cheers,
Carlos.