This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add x32 support to dynamic linker audit


On Thu, Mar 22, 2012 at 11:51 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> That's not the fix we want though.
>>
>> The types should match in name so as to make documenting easy and not
>> confuse developers.
>>
>> See my comments to H.J. regarding the original patch.
>>
>
> Sorry for that. I didn't noticed the warning on Linux/ia32. I am testing this:
> OK to install with a ChangeLog entry if it passes on Linux/x86-64 and
> Linux/ia32?
>
> Thanks.
>
>
> --
> H.J.
> ---
> diff --git a/sysdeps/generic/ldsodefs.h b/sysdeps/generic/ldsodefs.h
> index d4cbaba..9955430 100644
> --- a/sysdeps/generic/ldsodefs.h
> +++ b/sysdeps/generic/ldsodefs.h
> @@ -187,6 +187,8 @@ struct La_i86_regs;
> ?struct La_i86_retval;
> ?struct La_x86_64_regs;
> ?struct La_x86_64_retval;
> +struct La_x32_regs;
> +struct La_x32_retval;
> ?struct La_ppc32_regs;
> ?struct La_ppc32_retval;
> ?struct La_ppc64_regs;

This is the right fix. I just finished testing the same thing on x86.

Please check this in.

Thanks to everyone who noticed the new warnings.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]