This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix for crash in NSS when libc built with --enable-static-nssand exe built with -static
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Sun, 18 Mar 2012 13:58:00 +0000 (UTC)
- Subject: Re: [patch] Fix for crash in NSS when libc built with --enable-static-nssand exe built with -static
- References: <20120304192904.090C119096D@elbrus2.mtv.corp.google.com>
On Sun, 4 Mar 2012, Paul Pluzhnikov wrote:
> 2012-03-04 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * nss/nsswitch.c (__nss_lookup_function): Fix crash when configured
> with --enable-static-nss and using statically linked executable.
"Fix crash" isn't really a description of what changed in the source code
in the usual ChangeLog sense; the ChangeLog should say "what" changed.
As for the explanation of the change outside the ChangeLog entry, the
debugger output may be relevant, but an actual explanation in words of
what's going on would be helpful as well. You're evidently familiar with
this code, the reviewers quite likely are not. Could you explain what the
various values (ni->library->name, ni->name, fct_name) are supposed to be
here (both for static-nss and the normal case), and why, therefore, the
new code is correct and the old code isn't? Would the change ever have
any effect for the normal (non-static-nss) case?
Once the underlying change to make static NSS is in you should file a bug
report in Bugzilla for the present issue, if there isn't one already.
--
Joseph S. Myers
joseph@codesourcery.com