This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add LP_SIZE, OP_LP, ASM_ADDR and RXX_LP to x86_64/sysdep.h
On Fri, Mar 16, 2012 at 4:23 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Mar 16, 2012 at 4:03 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> It's hard to evaluate the wisdom of particular macro choices without
>> seeing all the cases where they're used.
>
> I pushed hjl/x32/master branch. ?You can take a look to
> see how they are used.
>
>> Instead of the several MOVE_LP et al, we could just have a single macro:
>>
>> #define LP(insn) ? ? ? ?insn##q
>
> Good idea.
>
>> (could be a different name). ?For parity, it seems appropriate to define
>> that for !__ASSEMBLER__ too, in case they are needed in asm().
>>
>
Here is the updated patch to define LP_OP instead of XXX_LP. I also
added LP_OP for !__ASSEMBLER__. OK to install?
Thanks.
--
H.J.
2012-03-16 H.J. Lu <hongjiu.lu@intel.com>
* sysdeps/x86_64/sysdep.h (LP_SIZE): New macro.
(LP_OP): Likewise.
(ASM_ADDR): Likewise.
(RAX_LP): Likewise.
(RBP_LP): Likewise.
(RBX_LP): Likewise.
(RCX_LP): Likewise.
(RDI_LP): Likewise.
(RSI_LP): Likewise.
(RSP_LP): Likewise.
(R8_LP): Likewise.
(R9_LP): Likewise.
(R10_LP): Likewise.
(R10_LP): Likewise.
(R11_LP): Likewise.
(R12_LP): Likewise.
(R13_LP): Likewise.
(R14_LP): Likewise.
(R15_LP): Likewise.
diff --git a/sysdeps/x86_64/sysdep.h b/sysdeps/x86_64/sysdep.h
index e455c60..f426fbd 100644
--- a/sysdeps/x86_64/sysdep.h
+++ b/sysdeps/x86_64/sysdep.h
@@ -95,4 +95,60 @@ lose: \
#define atom_text_section .section ".text.atom", "ax"
+/* Long and pointer size in bytes. */
+#define LP_SIZE 8
+
+/* Instruction to operate on long and pointer. */
+#define LP_OP(insn) insn##q
+
+/* Assembler address directive. */
+#define ASM_ADDR .quad
+
+/* Registers to hold long and pointer. */
+#define RAX_LP rax
+#define RBP_LP rbp
+#define RBX_LP rbx
+#define RCX_LP rcx
+#define RDI_LP rdi
+#define RDX_LP rdx
+#define RSI_LP rsi
+#define RSP_LP rsp
+#define R8_LP r8
+#define R9_LP r9
+#define R10_LP r10
+#define R11_LP r11
+#define R12_LP r12
+#define R13_LP r13
+#define R14_LP r14
+#define R15_LP r15
+
+#else /* __ASSEMBLER__ */
+
+/* Long and pointer size in bytes. */
+#define LP_SIZE "8"
+
+/* Assembler address directive. */
+#define ASM_ADDR ".quad"
+
+/* Instruction to operate on long and pointer. */
+#define LP_OP(insn) #insn "q"
+
+/* Registers to hold long and pointer. */
+#define RAX_LP "rax"
+#define RBP_LP "rbp"
+#define RBX_LP "rbx"
+#define RCX_LP "rcx"
+#define RDI_LP "rdi"
+#define RDX_LP "rdx"
+#define RSI_LP "rsi"
+#define RSP_LP "rsp"
+#define R8_LP "r8"
+#define R9_LP "r9"
+#define R10_LP "r10"
+#define R11_LP "r11"
+#define R12_LP "r12"
+#define R13_LP "r13"
+#define R14_LP "r14"
+#define R15_LP "r15"
+
#endif /* __ASSEMBLER__ */