This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Remove the `q' suffix in x86_64 PTR_MANGLE/PTR_DEMANGLE


On Fri, Mar 16, 2012 at 3:54 PM, Roland McGrath <roland@hack.frob.com> wrote:
> That looks fine to me.
>
> But don't you want to rotate by 9 rather than 17 when dealing with a 32-bit
> pointer, like the i386 version does?
>
> It could be genericized here by using a "i" constraint on an input argument
> that you compute from sizeof (void *).
>

Good point.  I will make the change.

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]