This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Add x86-64 ffsl alias only if __LP64__ is defined
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 16 Mar 2012 10:56:08 -0700 (PDT)
- Subject: Re: PATCH: Add x86-64 ffsl alias only if __LP64__ is defined
- References: <20120316174202.GA7547@intel.com>
> When __LP64__ isn't defined, ffsll != ffsl. This patch adds the check
> for __LP64__ when making ffsl alias. OK to install?
Assuming it's true that all supported GCC versions defined __LP64__,
then it's OK with the nits below fixed.
> * sysdeps/x86_64/ffsll.c: Add ffsl alias only if __LP64__ is
> defined.
Say "(ffsl): Define alias only under [__LP64__]."
> - Copyright (C) 1991,92,93,94,97,98,2001 Free Software Foundation, Inc.
> + Copyright (C) 1991,92,93,94,97,98,2001,2012
> + Free Software Foundation, Inc.
Copyright (C) 1991-2012 Free Software Foundation, Inc.
Thanks,
Roland