This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][TRY2] fix false multi-byte matches in some regularexpressions
Carlos O'Donell pÃÅe v Ät 16. 02. 2012 v 15:15 -0500:
> On Thu, Feb 16, 2012 at 2:39 PM, Stanislav Brabec <sbrabec@suse.cz> wrote:
> > Roland McGrath wrote:
> >> A change needs a ChangeLog entry, and it should mention the bugzilla
> >> number. A subtle issue such as this warrants an addition to the test
> >> suite.
> >
> > Here is the patch.
> >
> > I do not have a C language reproducer yet, just a command for sed using
> > glibc regexp. See another branch of this thread.
>
> I agree with Roland we really really need a test case for something as
> complicated as this issue.
Could I use sed for the test case? GNU sed uses libc regexp by default,
so the possible regression should be catched as well. I still have no C
language testcase that fails without the fix.
> Please review: http://sourceware.org/glibc/wiki/Contribution%20checklist
> * ChangeLog's should not be in the patch.
It says:
All patches for consideration must have ChangeLog entry updates...
> * ChangeLog is incorrectly formatted.
Fixed in the next mail.
--
Best Regards / S pozdravem,
Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o. e-mail: sbrabec@suse.cz
Lihovarskà 1060/12 tel: +49 911 7405384547
190 00 Praha 9 fax: +420 284 028 951
Czech Republic http://www.suse.cz/