This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix math functions triggering invalid exceptions
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Aurelien Jarno <aurelien at aurel32 dot net>
- Cc: libc-alpha at sources dot redhat dot com
- Date: Wed, 15 Feb 2012 20:55:52 +0000 (UTC)
- Subject: Re: [PATCH] Fix math functions triggering invalid exceptions
- References: <20120215184351.GA17446@hall.aurel32.net>
On Wed, 15 Feb 2012, Aurelien Jarno wrote:
> The patch below addresses the issue by using non-signaling
> floating-point comparisons, that is functions like isgreater, isless or
> isgreaterequal.
This looks fine except:
* In various places you are missing the space before the '(' in calls to
macros such as islessequal.
* When changing a file with an FSF copyright notice (as opposed to a Sun
copyright notice for files from fdlibm, for example), you need to update
the copyright dates unless they already include 2012. We've recently
concluded that as part of such an update it's OK to collapse all years
1991 and later in the copyright notice to a single range <first-year>-2012
rather than having a long comma-separated list any more.
So I think you should repost with those fixes, and then commit if noone
else spots any problems and if it's been tested on both an affected
platform and one that didn't previously have the issue you report.
--
Joseph S. Myers
joseph@codesourcery.com