This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap

From: Roland McGrath <roland at hack dot frob dot com>
To: Kees Cook <kees at outflux dot net>
Cc: Andreas Schwab <schwab at linux-m68k dot org>, Paul Eggert <eggert at cs dot ucla dot edu>, libc-alpha at sourceware dot org
Date: Mon, 6 Feb 2012 10:34:08 -0800 (PST)
Subject: Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
References: <20120206062537.GM4979@outflux.net><4F2F7E1C.5010506@cs.ucla.edu><m2mx8w6lcz.fsf@igel.home><20120206171706.GN4979@outflux.net>

> On Mon, Feb 06, 2012 at 04:18:52PM +0100, Andreas Schwab wrote:
> > Paul Eggert <eggert@cs.ucla.edu> writes:
> > 
> > >   all_done:
> > >     if (__builtin_expect (args_malloced != NULL, 0))
> > >       free (args_malloced);
> > 
> > No need for the NULL check.
> 
> Ah, perhaps I misunderstood earlier style requirements. I was told not to
> use implicit NULL tests. What're the other conventions around that?

Here he didn't mean to write "!args_malloced" (which is against our style).
He meant to call free unconditionally, since calling it with a null pointer
is a no-op.


Thanks,
Roland

References:
- [PATCH] vfprintf: validate nargs and maybe allocate from heap
  - From: Kees Cook
- Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
  - From: Paul Eggert
- Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
  - From: Andreas Schwab
- Re: [PATCH] vfprintf: validate nargs and maybe allocate from heap
  - From: Kees Cook

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]