This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [tile] support openat() in not-cancel.h
On 1/27/2012 6:13 PM, Ulrich Drepper wrote:
> On Fri, Jan 27, 2012 at 18:12, Roland McGrath <roland@hack.frob.com> wrote:
>> While that's possible, that doesn't make it the cleanest thing to do.
> It's certainly cleaner than conditionalizing the existing code. With
> a separate file all the arch-specific stuff is in one file and no
> conditionals are needed.
The problem is that there's no model for the dozen-odd files in
sysdeps/unix/sysv/linux/ to get the correct version of "not-cancel.h"; they
will all include the standard one, and break on Linux architectures using
the new asm-generic API. So, naively, we'd need to duplicate about 2,700
lines of code into sysdeps/unix/sysv/linux/generic/ to avoid modifying
not-cancel.h.
An alternative would be to move not-cancel.h somewhere overrideable by
architectures.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com