This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: follow-up on tile architecture changes
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Chris Metcalf <cmetcalf at tilera dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Thu, 26 Jan 2012 10:51:37 -0800 (PST)
- Subject: Re: follow-up on tile architecture changes
- References: <4EE66C80.3040600@tilera.com><20111213025158.50E9B2C098@topped-with-meat.com><4EE8C111.4020002@tilera.com><20111214173352.66CB62C0A6@topped-with-meat.com><4F206F3D.8060603@tilera.com>
> I went ahead and created a cmetcalf/tile_elf_h branch, following the
> instructions in http://sourceware.org/glibc/wiki/GlibcGit. If that's
> structurally the kind of thing you were looking for, that would be good to
> know.
Yes, that's the right thing to do (assuming cmetcalf is your username on
sourceware). Note that the git hooks disallow "non-fast-forward" pushes
even for private branches. You can defeat that constraint by a removal and
re-addition:
git push origin :cmetcalf/tile_elf_h
git push origin cmetcalf/tile_elf_h
> But based on the recent exchange between you and Joseph Myers I suspect it
> may make as much sense for me to directly commit the Tile-specific changes
> to the core. So I'll repost the series of changes; let me know if they are
> suitable for directly committing or whether you would like to commit them,
> and if so, whether I should create branches like the tile_elf_h branch for
> them.
It never hurts to publish a private branch. Then someone like me or Joseph
who is ready to declare it kosher can just do a git merge (or tell you it's
OK to, knowing precisely what you'll be pushing to master). I think it is
probably wise for someone like you who does not yet have a history of doing
direct commits to use the private branch method for a while first. When
there is a track record of your private branches getting merged without
any fixups required, then we'll be more confident about telling you to
commit a change yourself after just seeing the patch.
Thanks,
Roland