This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Improve 32 bit memchr, memrchr, rawmemchr with SSE2

From: Dmitrieva Liubov <liubov dot dmitrieva at gmail dot com>
To: Ulrich Drepper <drepper at gmail dot com>, libc-alpha at sourceware dot org
Date: Wed, 12 Oct 2011 12:29:59 +0400
Subject: Re: PATCH: Improve 32 bit memchr, memrchr, rawmemchr with SSE2
References: <CAHjhQ93pc2GC_L7hx6DiNzE9w26f9FetPQk8X9n+VCJ1YOanWQ@mail.gmail.com><CAOPLpQfrD-S6572SY1Xrjn83qJD7wbaQAQfBdfdUBvC9xMYPUQ@mail.gmail.com>

Hello,

I fixed it. I didn't notice memchr and rawmemchr implementations in
sysdeps/i386.

Change Log:

2011-10-12  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>

	* sysdeps/i386/i686/multiarch/Makefile (sysdep_routines): Add
	memchr-sse2 memchr-sse2-bsf
	memrchr-sse2 memrchr-sse2-bsf memrchr-c
	rawmemchr-sse2 rawmemchr-sse2-bsf

	* sysdeps/i386/i686/multiarch/memchr.S: New file.
	* sysdeps/i386/i686/multiarch/memchr-sse2.S: New file.
	* sysdeps/i386/i686/multiarch/memchr-sse2-bsf.S: New file.

	* sysdeps/i386/i686/multiarch/memrchr.S: New file.
	* sysdeps/i386/i686/multiarch/memrchr-c.c: New file.
	* sysdeps/i386/i686/multiarch/memrchr-sse2.S: New file.
	* sysdeps/i386/i686/multiarch/memrchr-sse2-bsf.S: New file.

	* sysdeps/i386/i686/multiarch/rawmemchr.S: New file.
	* sysdeps/i386/i686/multiarch/rawmemchr-sse2.S: New file.
	* sysdeps/i386/i686/multiarch/rawmemchr-sse2-bsf.S: New file.

	* string/memrchr.c
	(MEMRCHR): New macro.


--
Liubov Dmitrieva
Intel Corparation

2011/10/7 Ulrich Drepper <drepper@gmail.com>:
> On Mon, Sep 12, 2011 at 11:43, Dmitrieva Liubov
> <liubov.dmitrieva@gmail.com> wrote:
>> ? ? ? ?* string/memchr.c
>> ? ? ? ?(MEMCHR): New macro.
>> ? ? ? ?* string/rawmemchr.c
>> ? ? ? ?(RAWMEMCHR): New macro.
>
> Why would you need this? ?The fallback should be the implementation in
> sysdeps/i386. ?If that implementation is bad then it should be fixed
> up or removed. ?But I guess you just copied what is done for other
> functions.
>

Attachment: memchr_family_x86_32.patch
Description: Binary data

References:
- Re: PATCH: Improve 32 bit memchr, memrchr, rawmemchr with SSE2
  - From: Ulrich Drepper

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]