This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC - check for finite and Infinity parameters inIBM Long Double 128 fmal().
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- Cc: libc-alpha at sourceware dot org, Dave Flaherty <flaherty at linux dot vnet dot ibm dot com>
- Date: Wed, 7 Sep 2011 19:16:10 +0200
- Subject: Re: [PATCH] PowerPC - check for finite and Infinity parameters inIBM Long Double 128 fmal().
- References: <4E5391C3.10907@linux.vnet.ibm.com><CAAKybw9BhstBjWNoJwFBbY15PQNjWz1k8zQM3ACBWx+BSm_SXw@mail.gmail.com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Sep 07, 2011 at 10:49:27AM -0500, Ryan S. Arnold wrote:
> On Tue, Aug 23, 2011 at 6:40 AM, Dave Flaherty
> <flaherty@linux.vnet.ibm.com> wrote:
> > Check for finite/infinity parms in IBM Long Double 128 fmal( )
> >
> > This patch addresses some IBM Long Double 128 fmal () test-ldouble.out
> > and test-ildoubl.out failures. ÂIf the âxâ and âyâ parameters are
> > finite values and âzâ is infinity, the result of fmal () should be âzâ
> > not NaN.
> >
> > This patch is checked into ibm/2.13/master and can be
> > cherry-picked from commit 9cb11a4f1e562490f02ef634946ec015bf6e75e4
> >
> >
> > 2011-08-18 ÂDavid Flaherty Â<flaherty@linux.vnet.ibm.com>
> >
> > Â Â Â Â* sysdeps/ieee754/ldbl-128ibm/s_fmal.c: New file which checks
> > Â Â Â Âfor finite and infinity parameters.
>
> Ack!
>
> Please consider committing this patch. I've been running with it in my
> ibm/2.13 branch for a few weeks with no problems.
Well, all the patch does is work around a testsuite failure, the double
double fmal still doesn't do what fmal is supposed to do (though, the
question is what exactly it should do with the weirdo floating point format,
as the precision is variable).
That said, I guess the patch is a (tiny) improvement on what glibc does
right now.
Jakub