This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH] Fixes and optimizations for 32-bit sparc fabs*().
- From: David Miller <davem at davemloft dot net>
- To: libc-alpha at sourceware dot org
- Date: Mon, 05 Sep 2011 13:14:38 -0400 (EDT)
- Subject: [PATCH] Fixes and optimizations for 32-bit sparc fabs*().
We should not use the "stack/union return pointer" stack slot
as a termporary location to pop values in between the integer
and float registers. Instead, the argument slots should be
used.
Don't generate the fabs() using C, gcc makes a mess of it because it
cannot see that the incoming argument stack slots can be used to pop
values between the integer and float registers, so it allocates 104
bytes of stack space needlessly. Just generate this directly in asm.
Committed to master.
---
ChangeLog | 9 ++++++
sysdeps/sparc/sparc32/fpu/s_fabs.S | 29 ++++++++++++++++++++
sysdeps/sparc/sparc32/fpu/s_fabs.c | 11 -------
sysdeps/sparc/sparc32/fpu/s_fabsf.S | 4 +-
sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S | 29 ++++++++++++++++++++
.../sysv/linux/sparc/sparc32/sparcv9/fpu/Implies | 3 ++
6 files changed, 72 insertions(+), 13 deletions(-)
create mode 100644 sysdeps/sparc/sparc32/fpu/s_fabs.S
delete mode 100644 sysdeps/sparc/sparc32/fpu/s_fabs.c
create mode 100644 sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S
create mode 100644 sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/fpu/Implies
diff --git a/ChangeLog b/ChangeLog
index 411381e..0afcbc9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2011-09-05 David S. Miller <davem@davemloft.net>
+
+ * sysdeps/sparc/sparc32/fpu/s_fabsf.S: Use first argument
+ stack slot, rather than the struct return pointer slot.
+ * sysdeps/sparc/sparc32/fpu/s_fabs.c: Delete.
+ * sysdeps/sparc/sparc32/fpu/s_fabs.S: New file.
+ * sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S: Likewise.
+ * sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/fpu/Implies: Likewise.
+
2011-09-05 Ulrich Drepper <drepper@gmail.com>
[BZ #13144]
diff --git a/sysdeps/sparc/sparc32/fpu/s_fabs.S b/sysdeps/sparc/sparc32/fpu/s_fabs.S
new file mode 100644
index 0000000..425fab4
--- /dev/null
+++ b/sysdeps/sparc/sparc32/fpu/s_fabs.S
@@ -0,0 +1,29 @@
+/* Float absolute value, sparc32 version.
+ Copyright (C) 2011 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, write to the Free
+ Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+ 02111-1307 USA. */
+
+#include <sysdep.h>
+
+ENTRY (__fabs)
+ st %o0, [%sp+72]
+ st %o1, [%sp+76]
+ ldd [%sp+72], %f0
+ retl
+ fabss %f0, %f0
+END (__fabs)
+weak_alias (__fabs, fabs)
diff --git a/sysdeps/sparc/sparc32/fpu/s_fabs.c b/sysdeps/sparc/sparc32/fpu/s_fabs.c
deleted file mode 100644
index b883e6e..0000000
--- a/sysdeps/sparc/sparc32/fpu/s_fabs.c
+++ /dev/null
@@ -1,11 +0,0 @@
-#include <math.h>
-#include <math_ldbl_opt.h>
-
-double __fabs (double x)
-{
- return __builtin_fabs (x);
-}
-weak_alias (__fabs, fabs)
-#if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0)
-compat_symbol (libm, __fabs, fabsl, GLIBC_2_0);
-#endif
diff --git a/sysdeps/sparc/sparc32/fpu/s_fabsf.S b/sysdeps/sparc/sparc32/fpu/s_fabsf.S
index e148724..b233c62 100644
--- a/sysdeps/sparc/sparc32/fpu/s_fabsf.S
+++ b/sysdeps/sparc/sparc32/fpu/s_fabsf.S
@@ -21,8 +21,8 @@
#include <sysdep.h>
ENTRY (__fabsf)
- st %o0, [%sp+64]
- ld [%sp+64], %f0
+ st %o0, [%sp+68]
+ ld [%sp+68], %f0
retl
fabss %f0, %f0
END (__fabsf)
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S b/sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S
new file mode 100644
index 0000000..547840e
--- /dev/null
+++ b/sysdeps/sparc/sparc32/sparcv9/fpu/s_fabs.S
@@ -0,0 +1,29 @@
+/* Float absolute value, sparc32+v9 version.
+ Copyright (C) 2011 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, write to the Free
+ Software Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
+ 02111-1307 USA. */
+
+#include <sysdep.h>
+
+ENTRY (__fabs)
+ st %o0, [%sp+72]
+ st %o1, [%sp+76]
+ ldd [%sp+72], %f0
+ retl
+ fabsd %f0, %f0
+END (__fabs)
+weak_alias (__fabs, fabs)
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/fpu/Implies b/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/fpu/Implies
new file mode 100644
index 0000000..70568c5
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/sparcv9/fpu/Implies
@@ -0,0 +1,3 @@
+# We must list this here to move it ahead of the ldbl-opt code.
+sparc/sparc32/sparcv9/fpu
+sparc/sparc32/fpu
--
1.7.6.401.g6a319