This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Adding systemtap probe points in pthread library(slightly revised again)
- From: Roland McGrath <roland at redhat dot com>
- To: Rayson Ho <rho at redhat dot com>
- Cc: libc-alpha at sourceware dot org, systemtap at sources dot redhat dot com
- Date: Fri, 4 Feb 2011 11:03:58 -0800 (PST)
- Subject: Re: [PATCH] Adding systemtap probe points in pthread library(slightly revised again)
- References: <20110119185608.C32B518190D@magilla.sf.frob.com><1380329.143423.1296066249436.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com><20110126185428.51F111807AA@magilla.sf.frob.com><1296119488.1743.37.camel@computer><20110128072014.AA2F3183C1A@magilla.sf.frob.com><1296634321.13282.34.camel@computer>
> > I see. No such code should be actually using these macros. But it may
> > wind up indirectly including lowlevellock.h for some reason. Is that
> > what you saw? Please cite the particular compilation errors you saw.
>
> That's exactly the issue in the first place - lowlevellock.h is
> indirectly included in many places. Without the Makefile changes, IN_LIB
> is not defined for the non-library modules.
I've fixed that problem differently in the branch. It should now bomb
out--as we want it to--if any macros containing probes are actually used in
files that don't define IN_LIB, but won't just because of #include chains.
Thanks,
Roland