This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Accidental checkin?


"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Tue, Dec 14, 2010 at 7:47 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Tue, Dec 14, 2010 at 5:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>>> Hi,
>>>
>>> Commit 42acbb92c861e97a6e1293ea853db88342a1bf53:
>>>
>>> http://sourceware.org/git/?p=glibc.git;a=commit;h=42acbb92c861e97a6e1293ea853db88342a1bf53
>>>
>>> changed
>>>
>>> sysdeps/i386/i686/multiarch/strcmp.S
>>>
>>> without ChangeLog entry. ÂIs that an accidental checkin?
>>>
>>
>> This change caused:
>>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=12318
>>
>
> That change has a typo.

It is bogus in its entirety.  It uses a call clobbered register around a
function call.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]