This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Various P7-optimized string functions


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 08/18/2010 09:08 AM, Luis Machado wrote:
> +++ b/sysdeps/powerpc/powerpc32/power7/memchr.S
> @@ -0,0 +1,170 @@
> +/* Optimized memchr implementation for PowerPC64 using cmpb.

These are Power7 files and this should be mentioned in the comment.  You
are not differentiating based on the availability of the cmpb feature
(whatever this is) but instead compile it for Power7.

- -- 
â Ulrich Drepper â Red Hat, Inc. â 444 Castro St â Mountain View, CA â
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (GNU/Linux)

iEYEARECAAYFAkxsY7UACgkQ2ijCOnn/RHRKSwCgpqGtBaOmsCyU/ghI2+SK1KAR
ZXMAn0UDSgpbOieNtd1tbYOL//pmZiAU
=bb92
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]