This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/2] Add CFI directives for pthread_cond_(timed)wait

From: Richard Henderson <rth at twiddle dot net>
To: dino at in dot ibm dot com
Cc: libc-alpha at sources dot redhat dot com, Ulrich Drepper <drepper at redhat dot com>, Darren Hart <dvhltc at us dot ibm dot com>,tglx at linutronix dot de
Date: Tue, 17 Nov 2009 08:24:45 -0800
Subject: Re: [PATCH 1/2] Add CFI directives for pthread_cond_(timed)wait
References: <20091117133341.GC6042@in.ibm.com> <20091117133543.GA27366@in.ibm.com>

On 11/17/2009 05:35 AM, Dinakar Guniguntala wrote:

  	addl	$FRAME_SIZE, %esp
-.Laddl:
+	cfi_adjust_cfa_offset(-FRAME_SIZE);

.cfi_remember_state before the adjust.

  18:	popl	%ebx
-.Lpop_ebx:
+	cfi_adjust_cfa_offset(-4)
+	cfi_restore(%edi)

Wrong register restored.

ret

+	cfi_adjust_cfa_offset(4 * 4 + FRAME_SIZE)
+	cfi_offset(%ebp, -8)
+	cfi_offset(%edi, -12)
+	cfi_offset(%esi, -16)
+	cfi_offset(%ebx, -20)

.cfi_restore_state.

Same changes in both copies.

r~

References:
- [PATCH 0/2] Add Requeue-PI support for x86 arch
  - From: Dinakar Guniguntala
- [PATCH 1/2] Add CFI directives for pthread_cond_(timed)wait
  - From: Dinakar Guniguntala

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]