This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Support binutils 2.100 and 3.0


2009-09-10 18:06:27 H.J. Lu napisaÅ(a):
> On Wed, Sep 9, 2009 at 6:44 PM, Arfrever Frehtes Taifersar
> Arahesis<arfrever.fta@gmail.com> wrote:
> > 2009-09-05 17:47:10 H.J. Lu napisaÅ(a):
> >> @@ -897,10 +897,10 @@ AC_SUBST(MIG)dnl Needed by sysdeps/mach/configure.in
> >>  # Accept binutils 2.13 or newer.
> >
> >     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> >>  AC_CHECK_PROG_VER(AS, $AS, --version,
> >>                 [GNU assembler.* \([0-9]*\.[0-9.]*\)],
> >> -               [2.1[3-9]*|[2-9].[2-9]*], AS=: critic_missing="$critic_missing as")
> >> +               [2.1[3-9]*|2.1[0-9][0-9]*|2.[2-9][0-9]*|[3-9].*], AS=: critic_missing="$critic_missing as")
> >
> > It still matches 2.9.
> >
> 
> How does it match 2.9?

Actually I tested the version which was actually committed:
http://sourceware.org/git/?p=glibc.git;a=commitdiff;h=0549ce8ec1f66a41c59815e50dd48ffd74fabb52

'2.[2-9]*' matches '2.9'.

Additionally both versions (from your e-mail and from this commit) don't match
'3.0' in the second check due to M4 interpretation of [ ] quotes.

> @@ -4904,7 +4904,7 @@ $as_echo_n "checking version of $LD... " >&6; }
>    ac_prog_version=`$LD --version 2>&1 | sed -n 's/^.*GNU ld.* \([0-9][0-9]*\.[0-9.]*\).*$/\1/p'`
>    case $ac_prog_version in
>      '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;;
> -    2.1[3-9]*|[2-9].[2-9]*)
> +    2.1[3-9]*|2.1[0-9][0-9]*|2.[2-9]*|3-9.*)

                                         ^^^

>         ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;;
>      *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;;

-- 
Arfrever Frehtes Taifersar Arahesis

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]