This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] sh: clone little optimization
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: carmelo73 at gmail dot com
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 27 Aug 2008 07:44:08 +0900 (JST)
- Subject: Re: [PATCH] sh: clone little optimization
- References: <2ccd6e3c0808260837y50179f88m48e923a1068a84f5@mail.gmail.com>
"Carmelo Amoroso" <carmelo73@gmail.com> wrote:
> attached patch tries to optimize a little clone implementation for sh
> by loading the r3 register (for holding syscall number) into a delay slot.
[snip]
> + bf/s 1f
> + mov #+SYS_ify(clone), r3
> +0:
One minor style issue. For SH .S files, we usually add a space
at the head of the instruction in a delayed slot. You can see
other examples in clone.S.
The patch looks ok with that change and an appropriate ChangeLog
entry.
Regards,
kaz