This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] speedup matching of ^$ and cleanup some code in regex
- From: "Carlos O'Donell" <carlos at systemhalted dot org>
- To: "Paolo Bonzini" <bonzini at gnu dot org>
- Cc: "Glibc Development" <libc-alpha at sourceware dot org>
- Date: Thu, 24 Apr 2008 16:21:58 -0400
- Subject: Re: [PATCH] speedup matching of ^$ and cleanup some code in regex
- References: <48109FD0.3050803@gnu.org>
On Thu, Apr 24, 2008 at 10:57 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
> However, some complications in building the NFA prevent this from fixing
> the problem. Therefore, this patch cleans up the handling of anchors so that
> tests on type == ANCHOR are not necessary anymore. When creating the NFA
> (calc_first), I move the opr.ctx_type to the constraint field of re_token_t,
> and then I always look at it unconditionally, without special-casing
> ANCHORs. This also allows some simplification of duplicate_node_closure.
>
> Patch at http://sourceware.org/bugzilla/attachment.cgi?id=2690&action=view
Paolo,
Please remember to reference the original BZ #, in this case:
http://sourceware.org/bugzilla/show_bug.cgi?id=6395
What testing have you done to verify functionality is preserved?
Cheers,
Carlos.