This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pthread locking code - C vs. ASM


Mike Frysinger wrote:
On Monday 21 January 2008, Gilles Carry wrote:

Is asm code supposed to do exactly the same as C code?


of course ... things would be broken otherwise


I recently had a case when I wanted to modify pthread_cond_signal.c and it
did not compile because of unexisting syscall macros.


you probably didnt include the right headers

Actually, pthread_cond_signal.c uses the macro lll_futex_wake_unlock which is not defined for i386.


Should C code be the reference? Should asm be modified only when we are
sure C is ok? It is a problem when people change asm code without updating
the underlying C files.


you should modify whatever your target platform uses

then again, i'd wonder why you were mucking around the libc code in the first place ...

I'm not sure I get the meaning of your last remark.


-gilles


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]